Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messages sent by bots fail WCAG AA contrast requirements #25808

Closed
robintown opened this issue Jul 14, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11273
Closed

Messages sent by bots fail WCAG AA contrast requirements #25808

robintown opened this issue Jul 14, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11273
Assignees
@germain-gg
Labels
A11y A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. View a message sent by a bot, such as those in the This Week In Matrix room

Outcome

What did you expect?

The text contrast ratio should meet accessibility requirements

What happened instead?

Screenshot 2023-07-14 at 10-08-23 Element 10 This Week in Matrix (TWIM)
Screenshot 2023-07-14 at 10-56-41 WebAIM Contrast Checker

Operating system

NixOS unstable

Browser information

Firefox 114.0.1

URL for webapp

develop.element.io

Application version

Element version: a84349f-react-eced103458e2-js-0b193f466562 Olm version: 3.2.14

Homeserver

Not relevant

Will you send logs?

No
@robintown robintown added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Timeline A11y O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 14, 2023
@t3chguy
Copy link
Member

t3chguy commented Jul 14, 2023

This looks to be due to an opacity: 0.6 present

Given it is even worse than that of staging this is a regression & blocker

image

@germain-gg germain-gg self-assigned this Jul 16, 2023
germain-gg pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2023
Fix color contrast of notice events
3f6c610 
Fixes element-hq/element-web#25808
@germain-gg germain-gg mentioned this issue Jul 17, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2023
Fix colour regressions (#11273)
5d4153f 
* Fix color contrast of notice events

Fixes element-hq/element-web#25808

* Restore alert color for highlighted events

Fixes element-hq/element-web#25788

* Fix quote border for highlighted events

Fixes element-hq/element-web#25811

* Fix media background mixing with event highlighted

Fixes element-hq/element-web#25812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A11y A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix colour regressions matrix-org/matrix-react-sdk
3 participants
@germain-gg @t3chguy @robintown