Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jitsi Widget should allow external Jitsi Servers #5048

Closed
m1ndgames opened this issue Sep 15, 2017 · 13 comments · Fixed by #12780
Closed

Jitsi Widget should allow external Jitsi Servers #5048

m1ndgames opened this issue Sep 15, 2017 · 13 comments · Fixed by #12780
Assignees
@turt2live
Labels
P1 T-Enhancement

Comments

@m1ndgames
Copy link

Description

The Jitsi Widget in Riot provides a jitsi.riot.im url.
We dont want to use external services and prefer to host everything ourself.

The Widget should allow that an external jitsi room url can be entered manually.

Steps to reproduce

  • Enter a Room
  • Create a Jitsi Widget
  • It provides a hardcoded jitsi.riot.im URL.

Version information

Riot Web 0.12.2 Release

  • Platform: web (in-browser)

For the web app:

  • Browser: Chrome, Firefox?
  • OS: Desktop: Arch Linux, Server: Debian 9
  • URL: private, but applies to any room.
@t3chguy
Copy link
Member

t3chguy commented Sep 15, 2017 •
edited
Loading

We dont want to use external services and prefer to host everything ourself.

The panel you see to add the Jitsi widget, Modular, is not possible to host yourself anyway.

Nothing to stop you using Custom Widget via Modular or via state events, but Jitsi Widget with custom jitsi urls is planned

@m1ndgames
Copy link
Author

I guess you mean the integration server scalar.vector.im?

Why is this hosted by vector, and not part of the riot web package?

@t3chguy
Copy link
Member

t3chguy commented Sep 15, 2017

Because it controls services that are ran by vector, like their go-neb instance and their bridges. It is proprietary as in the future will provide premium (paid) services. None of the existing services will become paid, additional ones will be added.

@m1ndgames
Copy link
Author

I understand, thanks for clarification.

@t3chguy
Copy link
Member

t3chguy commented Sep 18, 2017

but Jitsi Widget with custom jitsi urls is planned

leave this issue open to track that

@t3chguy t3chguy reopened this Sep 18, 2017
@Cadair Cadair mentioned this issue Apr 25, 2023
Open
@turt2live turt2live mentioned this issue Dec 14, 2017
Closed
@Jimmy-SafeCash
Copy link

Has there been any update on this? It would be a great addition to the platform as it'd compliment the decentralisation that the rest of the platform affords.

@MTRNord
Copy link
Contributor

MTRNord commented Dec 31, 2017 •
edited
Loading

I know this is a upstream issue but Dimension by @turt2live supports this (a alternativ to scalar. Selfhosted)

@Jimmy-SafeCash
Copy link

Any update on this?

@ara4n
Copy link
Member

ara4n commented Feb 7, 2018

the guy working on it left the project, and we haven't found bandwidth to progress it since.

@Jimmy-SafeCash
Copy link

Just wondering if this feature has made it onto any future update path yet?

@turt2live turt2live mentioned this issue Oct 7, 2019
Closed
@sundh4
Copy link

sundh4 commented Jan 16, 2020

Hello all,
I would like to have this same feature as well, so i can use my own jitsi server on the riot web client. Any update regarding this? Thank you.

@lephisto
Copy link

lephisto commented Mar 9, 2020

Updates? Where to get rid of the public jit.si?

@t3chguy
Copy link
Member

t3chguy commented Mar 9, 2020

By default it actually uses jitsi.riot.im not the public jit.si.

@t3chguy t3chguy mentioned this issue Mar 16, 2020
Closed
@turt2live turt2live added P1 and removed P2 labels Mar 17, 2020
@turt2live turt2live self-assigned this Mar 17, 2020
turt2live added a commit that referenced this issue Mar 18, 2020
@turt2live
Use a local widget wrapper for Jitsi calls
e1eb16c 
Effectively fixes #11074
Effectively fixes #7112
Fixes #6930
Fixes Jitsi widgets not working for guests (#8933)
Fixes #5048

Previously we were relying on an integration manager to be defined, functional, and alive in order to join Jitsi calls. This commit changes this so we aren't reliant on an integration manager for Jitsi calls at all, and gives people the option of choosing a Jitsi server via the config.json.

This side is just the wrapper/shell: the logic is mostly in the react-sdk (to be linked via PRs). This layer simply has an HTML file exported that can be used to render a Jitsi widget, and the react-sdk constructs a URL to access it locally. This is similar to how the mobile apps handle Jitsi widgets: instead of iframing the widget URL directly into the app, they pull apart the widget information and natively render it. We're effectively doing the same here by parsing the widget options and using our local wrapper instead of whatever happens to be defined in the widget state event.

Integration managers should still continue to offer a widget URL for Jitsi widgets as this is what the spec requires.

A large part of this is based upon Dimension's handling of Jitsi and widgets in general: a license has been granted to allow Riot (and therefore the react-sdk) to use the code and be inspired by it.
@turt2live turt2live mentioned this issue Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P1 T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a local widget wrapper for Jitsi calls element-hq/element-web
10 participants
@jryans @turt2live @ara4n @MTRNord @lampholder @t3chguy @m1ndgames @Jimmy-SafeCash @lephisto @sundh4