Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve watchers for settings #8936

Closed
turt2live opened this issue Feb 25, 2019 · 1 comment
Closed

Improve watchers for settings #8936

turt2live opened this issue Feb 25, 2019 · 1 comment
Assignees
@turt2live
Labels
P1 T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

As per review feedback on matrix-org/matrix-react-sdk#2686 (review)

This is 100% the responsibility of myself to do, and should be treated as top priority post-release.
@turt2live turt2live added T-Task Tasks for the team like planning P1 decluttering labels Feb 25, 2019
@turt2live turt2live self-assigned this Feb 25, 2019
@turt2live turt2live mentioned this issue Feb 25, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 26, 2019
@turt2live
Use a global WatchManager for settings
ebcebfa 
Fixes element-hq/element-web#8936

Watchers are now managed by the SettingsStore itself through a global/default watch manager. As per the included documentation, the watch manager dispatches updates to callbacks which are redirected by the SettingsStore for consumer safety.
@turt2live turt2live mentioned this issue Feb 26, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 26, 2019
@turt2live
Use a global WatchManager for settings
93673ef 
Fixes element-hq/element-web#8936

Watchers are now managed by the SettingsStore itself through a global/default watch manager. As per the included documentation, the watch manager dispatches updates to callbacks which are redirected by the SettingsStore for consumer safety.
@turt2live
Copy link
Member Author

Fixed by matrix-org/matrix-react-sdk#2705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P1 T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turt2live