This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use a global WatchManager for settings #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#8936 Watchers are now managed by the SettingsStore itself through a global/default watch manager. As per the included documentation, the watch manager dispatches updates to callbacks which are redirected by the SettingsStore for consumer safety.
turt2live
force-pushed
the
travis/fix-monitored-settings
branch
from
8fcfb01
to
fbffd3e
Compare
bwindels
approved these changes
Feb 27, 2019
| } | ||
| console.log(`Starting watcher for ${settingName}@${roomId || '<null room>'}`); | ||
| SettingsStore._watchers[watcherId] = localizedCallback; | ||
| defaultWatchManager.watchSetting(settingName, roomId, localizedCallback); |
There was a problem hiding this comment.
You could wonder now if the WatchManager is still needed. It only ever has one watcher for a setting, so it might further simplify by bringing it into SettingsStore and merging it with _watchers. Handlers could just call notifyUpdate on SettingsStore.
There was a problem hiding this comment.
I kinda want to keep as much as possible out of the store so it doesn't become a 1000 line monster. Ideally I'd also move a bunch of the watcher stuff out, but this is fine for now I think.
su-ex
added a commit
to SchildiChat/matrix-react-sdk
that referenced
this pull request
Sep 28, 2022
* Bump IDB crypto store version ([\matrix-org#2705](matrix-org/matrix-js-sdk#2705)).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8936
Note to the reviewer: It may be easier to review this commit-by-commit. I've included some attempts to make the diff more legible for the settings documentation.
Watchers are now managed by the SettingsStore itself through a global/default watch manager. As per the included documentation, the watch manager dispatches updates to callbacks which are redirected by the SettingsStore for consumer safety.