Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a local widget wrapper for Jitsi calls #12780

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Commits on Mar 18, 2020

  1. Use a local widget wrapper for Jitsi calls

    Effectively fixes #11074
    Effectively fixes #7112
    Fixes #6930
    Fixes Jitsi widgets not working for guests (#8933)
    Fixes #5048
    
    Previously we were relying on an integration manager to be defined, functional, and alive in order to join Jitsi calls. This commit changes this so we aren't reliant on an integration manager for Jitsi calls at all, and gives people the option of choosing a Jitsi server via the config.json.
    
    This side is just the wrapper/shell: the logic is mostly in the react-sdk (to be linked via PRs). This layer simply has an HTML file exported that can be used to render a Jitsi widget, and the react-sdk constructs a URL to access it locally. This is similar to how the mobile apps handle Jitsi widgets: instead of iframing the widget URL directly into the app, they pull apart the widget information and natively render it. We're effectively doing the same here by parsing the widget options and using our local wrapper instead of whatever happens to be defined in the widget state event.
    
    Integration managers should still continue to offer a widget URL for Jitsi widgets as this is what the spec requires.
    
    A large part of this is based upon Dimension's handling of Jitsi and widgets in general: a license has been granted to allow Riot (and therefore the react-sdk) to use the code and be inspired by it.
    turt2live committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    e1eb16c View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Configuration menu
    Copy the full SHA
    09e26d0 View commit details
    Browse the repository at this point in the history