Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to disable notification for invites #1955

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 4, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add setting to disable notification for invites.
Need SDK release with matrix-org/matrix-rust-sdk#2908

Motivation and context

Closes #1944

Screenshots / GIFs

image
  • recorded ones.

Tests

  • Disable the new option
  • Invite the user to a room
  • observe that no notification is displayed

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty force-pushed the feature/bma/notificationForInvites branch from 879202d to 4632ab6 Compare December 4, 2023 16:51
@ElementBot
Copy link
Collaborator

ElementBot commented Dec 4, 2023

Warnings
⚠️

gradle/libs.versions.toml#L6 - A newer version of com.android.tools.build:gradle than 8.1.4 is available: 8.2.0

⚠️

gradle/libs.versions.toml#L22 - A newer version of androidx.compose.compiler:compiler than 1.5.4 is available: 1.5.5

Generated by 🚫 dangerJS against 2584d2f

Copy link
Contributor

github-actions bot commented Dec 4, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YHypYM

Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4b80914) 67.72% compared to head (2584d2f) 67.73%.
Report is 6 commits behind head on develop.

Files Patch % Lines
...ces/impl/notifications/NotificationSettingsView.kt 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1955      +/-   ##
===========================================
+ Coverage    67.72%   67.73%   +0.01%     
===========================================
  Files         1319     1319              
  Lines        33357    33380      +23     
  Branches      7146     7149       +3     
===========================================
+ Hits         22590    22610      +20     
- Misses        7347     7349       +2     
- Partials      3420     3421       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 5, 2023
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 5, 2023
@bmarty bmarty marked this pull request as ready for review December 5, 2023 08:54
@bmarty bmarty requested a review from a team as a code owner December 5, 2023 08:54
@bmarty bmarty requested review from ganfra and removed request for a team December 5, 2023 08:54
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty merged commit 8f5fed4 into develop Dec 5, 2023
17 checks passed
@bmarty bmarty deleted the feature/bma/notificationForInvites branch December 5, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification setting for invites
3 participants