-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose is_invite_for_me_enabled
and set_invite_for_me_enabled
in notification settings
#2908
Conversation
…notification settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run cargo fmt
to fix the formatting. Otherwise LGTM.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2908 +/- ##
=======================================
Coverage ? 82.77%
=======================================
Files ? 220
Lines ? 22430
Branches ? 0
=======================================
Hits ? 18566
Misses ? 3864
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Done, but there are more changes than expected, is there a formatting configuration that I should have on my side, or is it OK to include all those changes in this PR? |
You can run Congrats on your first Rust PR! May it be the first of a long lineage 🥳 🦀 |
eefe45c
to
e879675
Compare
OK, thanks, should be OK now. |
Just doing a small copy paste for my first Rust PR.
Tested OK using EXA (PR coming there too)
Context: element-hq/element-x-android#1944
Let me know if there is something else to do (changelog entry - not sure this is necessary here, since it's a small change, etc.)
Signed-off-by: benoitm@element.io