Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose is_invite_for_me_enabled and set_invite_for_me_enabled in notification settings #2908

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

bmarty
Copy link
Contributor

@bmarty bmarty commented Dec 4, 2023

Just doing a small copy paste for my first Rust PR.

Tested OK using EXA (PR coming there too)

Context: element-hq/element-x-android#1944

Let me know if there is something else to do (changelog entry - not sure this is necessary here, since it's a small change, etc.)

  • Public API changes documented in changelogs (optional)

Signed-off-by: benoitm@element.io

@bmarty bmarty requested a review from a team as a code owner December 4, 2023 13:54
@bmarty bmarty requested review from jplatte and removed request for a team December 4, 2023 13:54
Copy link
Collaborator

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run cargo fmt to fix the formatting. Otherwise LGTM.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@045d94a). Click here to learn what that means.
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2908   +/-   ##
=======================================
  Coverage        ?   82.77%           
=======================================
  Files           ?      220           
  Lines           ?    22430           
  Branches        ?        0           
=======================================
  Hits            ?    18566           
  Misses          ?     3864           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty
Copy link
Contributor Author

bmarty commented Dec 4, 2023

Please run cargo fmt to fix the formatting. Otherwise LGTM.

Done, but there are more changes than expected, is there a formatting configuration that I should have on my side, or is it OK to include all those changes in this PR?

@bnjbvr
Copy link
Member

bnjbvr commented Dec 4, 2023

You can run cargo xtask fixup style which runs the expected nightly version of Cargo.

Congrats on your first Rust PR! May it be the first of a long lineage 🥳 🦀

@bmarty bmarty force-pushed the bma/notificationForInvitationToggle branch from eefe45c to e879675 Compare December 4, 2023 15:31
@bmarty
Copy link
Contributor Author

bmarty commented Dec 4, 2023

You can run cargo xtask fixup style which runs the expected nightly version of Cargo.

Congrats on your first Rust PR! May it be the first of a long lineage 🥳 🦀

OK, thanks, should be OK now.

@jplatte jplatte merged commit 1337fdf into main Dec 4, 2023
35 checks passed
@jplatte jplatte deleted the bma/notificationForInvitationToggle branch December 4, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants