-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two sync loop experimental solution to decrypt push notifications #1082
Conversation
Generated by 🚫 Danger Swift against 53dc155 |
30a383b
to
7407ad7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments inline but it looks good to me 👍
acd9933
to
2fba9cc
Compare
4394ff9
to
83f063a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried about isSyncing and merging together the 2 loops, otherwise it looks good to me 👍
83f063a
to
bbff3d1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1082 +/- ##
===========================================
- Coverage 42.37% 41.84% -0.54%
===========================================
Files 393 396 +3
Lines 24830 24983 +153
Branches 12992 13063 +71
===========================================
- Hits 10522 10454 -68
- Misses 14029 14248 +219
- Partials 279 281 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cecc567
to
99cd55d
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This is using an external matrix rust sdk experimental branch, not merged yet in main, so it will likely fail to compile on CI for now.
The idea is to use the notification sync (which I feel it should be renamed to encryption or decryption sync) to actually update the keys.
The sync runs both in the main app and in the NSE, we can now wait for the notification to be fully decrypted (we wait for about 10 seconds at most for now but it takes way less) before showing it to the user.
This requires to not use all common extensions but remove e2ee and toDeviceEvents from the normal sync, since the notification sync does that job instead.Updated to work with RoomListAPI
Adding also an ff, to enable or not this, since could require some testing for quite some in the nightly time before we know if is stable or not.