Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2360 - Add support for manually marking rooms as unread #2408

Merged
merged 7 commits into from
Feb 5, 2024
Merged

Fixes #2360 - Add support for manually marking rooms as unread #2408

merged 7 commits into from
Feb 5, 2024

Conversation

stefanceriu
Copy link
Member

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift#L223 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)
⚠️

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift#L225 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)
⚠️

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift#L227 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)
⚠️

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift#L229 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

Generated by 🚫 Danger Swift against 1f1e774

@stefanceriu stefanceriu marked this pull request as ready for review February 5, 2024 15:12
@stefanceriu stefanceriu requested a review from a team as a code owner February 5, 2024 15:12
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team February 5, 2024 15:12
Velin92
Velin92 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few suggestions

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu merged commit 9915a33 into develop Feb 5, 2024
3 of 4 checks passed
@stefanceriu stefanceriu deleted the stefan/markAsRead branch February 5, 2024 16:06
@pixlwave pixlwave mentioned this pull request Feb 6, 2024
Merged
@stefanceriu stefanceriu mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty left review comments

@Velin92 Velin92 Velin92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanceriu @bmarty @Velin92