Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Add licenses for JavaScript according to GNU recommendation #209

Open
Huy-Ngo opened this issue Dec 7, 2020 · 2 comments · Fixed by #301
Open

[Request] Add licenses for JavaScript according to GNU recommendation #209

Huy-Ngo opened this issue Dec 7, 2020 · 2 comments · Fixed by #301

Comments

@Huy-Ngo
Copy link

Huy-Ngo commented Dec 7, 2020

The code in this project is licensed under the Apache License, a free license. However, the license is not embedded into the code in the way GNU recommended. This causes browsers with LibreJS to treat it as nonfree JS, thus blocking it. Please add these license in such format.

LibreJS has detected the following pieces of code and blocked them:
@bwindels
Copy link
Contributor

do we need to add the full license or just the short header we do in most of the source files?

Johennes added a commit to Johennes/hydrogen-web that referenced this issue Mar 27, 2021
@Johennes
Add license comments to make GNU LibreJS accept Hydrogen's JS
37bb078 
This adds proper license comments to all _internal_ JS scripts in the /target
build. This way the code self-identifies as Apache-2.0 which prevents LibreJS
from blocking it.

Closes: element-hq#209

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
This was referenced Mar 27, 2021
Merged
Closed
@bwindels bwindels reopened this Dec 8, 2021
@bwindels bwindels mentioned this issue Dec 8, 2021
Merged
13 tasks
@bwindels
Copy link
Contributor

bwindels commented Dec 8, 2021

Had to remove the support added in #301 when converting the build system to vite in #548. WIP to reenable the license headers in https://github.com/vector-im/hydrogen-web/tree/bwindels/librejs-vite-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add license comments to make GNU LibreJS accept Hydrogen's JS Johennes/hydrogen-web
2 participants
@bwindels @Huy-Ngo