-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert develop server and build system to using Vite #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or not understood by tsc in any case
otherwise they don't get transpiled for some reason
bwindels
force-pushed
the
bwindels/vite-mvp
branch
from
November 8, 2021 10:14
0757d3e
to
ffef493
Compare
note that these have already been converted to javascript by vite
as it is a devDependency and can end up in the legacy bundle under circumstances
also better naming in service worker plugin
some of these are for the ie11 legacy build, which has been postponed. They will be brougth back when we bring back the legacy build
bwindels
force-pushed
the
bwindels/vite-mvp
branch
from
December 9, 2021 17:05
f879262
to
5c5193e
Compare
This seems good to go 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index.htmlthe bundlebuild bundle for IE11punting this for nowmake themes work againremoving the very basic theme support so far to bring it back in Theming ground work #531add license header again to bundlegiven the dependencies have multiple licenses and are bundled into onevendor
bundle, not sure how to indicate these licenses. For now, I'll remove LibreJS support that was introduced in Add license comments to make GNU LibreJS accept Hydrogen's JS #301, and have reopened [Request] Add licenses for JavaScript according to GNU recommendation #209.transpile web workerpunting this as the built-in vite plugin prevents us from usingimportScripts
for the olm worker, which we use to load olm. We'll need to be careful to not cause Empty page with "SyntaxError: expected expression, got '.'" on Firefox 60esr and Chromium 73 #230 in the worker here, and not transpiling it will again mean no IE11 support for now. The long term plan is to use our own plugin, see Allow SDK usage from service worker #292Related to #529
Fixes #230