Implement the settings portal #38

alice-mkh · 2021-09-19T21:45:40Z

Thankfully, we don't have to implement everything - settings portal
can have multiple implementations and will combine settings from all
of them.

Fixes #37

alice-mkh

A self-review for things that should probably be changed before merging.

settings-portal/Settings.vala

alice-mkh · 2021-09-19T21:50:01Z

settings-portal/Settings.vala

+    public abstract string find_user_by_name (string username) throws GLib.Error;
+}
+
+private class AccountsServiceMonitor : GLib.Object {


There are multiple options for this:

Use Granite instead (and allow Granite to use both portal and accountsservice directly + a way to disable portal there)

Have this in the same process as the settings daemon itself, then it can be accessed directly from there instead.

This one is still an open question. We can also leave it as is, of course.

OTOH if it's in the same process Granite will need an override to not try to access portal from portal itself too, having it separate doesn't require it as long as the portal binary doesn't link to granite.

settings-portal/Main.vala

Thankfully, we don't have to implement everything - settings portal can have multiple implementations and will combine settings from all of them. Fixes elementary#37

danirabbit · 2021-09-19T22:14:54Z

Just wanted to say thank you so much for doing all of this work! It's massively appreciated ❤️

Marukesu

Some comments, thanks for working in this.

settings-portal/Error.vala

settings-portal/Settings.vala

Marukesu

Works as expected.

However, one thing i noticed is, the portal frontend sort settings implementations by name not by the backend UseIn key, so the GTK portal will have priority.

alice-mkh · 2021-09-21T22:04:15Z

Ugh, and in that case -gtk will be prioritized over -gnome as well. Maybe it should have a separate priority key.

GeorgesStavracas · 2021-09-22T13:18:12Z

Ugh, and in that case -gtk will be prioritized over -gnome as well. Maybe it should have a separate priority key.

To the best of my knowledge, "gnome" is sorted before "gtk". Here's some evidence!

>>> a = ['gtk','gnome','pantheon','kde']
>>> a.sort()
>>> print(a)
['gnome', 'gtk', 'kde', 'pantheon']

alice-mkh · 2021-09-22T13:23:52Z

gnome.portal
gtk.portal
io.elementary.settings-daemon.portal

Ah indeed, I assumed it was org.gnome.Portal or sth without checking.

GeorgesStavracas · 2021-09-22T13:25:21Z

For what is worth, I remember talking to Matthias about a more sophisticated sorting in the past, and the conclusion was that we would cross this bridge when it comes to it. Seems like the time to to cross that bridge has come.

settings-portal/meson.build

settings-portal/Settings.vala

davidmhewitt

Just one super minor tweak and then this is good, thanks for all your hard work! ❤️

I have a couple of questions that would be good to have clarified here for posterity:

From reading above, it sounds like the GTK and GNOME portals take precedence over this elementary portal based on the current code in xdg-desktop-portal. What I understand from that is that at the point where we get a version of the GNOME (or GTK) portal that starts returning a value for the org.freedesktop.appearance.color-scheme key, then that portal implementation will be considered the source of truth for that value? Meaning that this won't work right because our settings pane will be writing to AccountsService and the "main" portal will be reading from whatever the GNOME backend implementation is? So it's not a blocker to merging this right now, but there's a piece of work still outstanding here to get more complicated prioritisation in xdg-portal-gtk, or we need to work around this somehow in elementary in the future?

Secondly, am I correct that the work required in Granite to have it read from here is essentially a D-Bus call to org.freedesktop.portal.Settings Read ? There's not a "nice" GSettings-esque way of doing it essentially because of this feature request? https://gitlab.gnome.org/GNOME/glib/-/issues/2213

settings-portal/Main.vala

alice-mkh · 2021-10-06T19:39:13Z

but there's a piece of work still outstanding here to get more complicated prioritisation in xdg-portal-gtk, or we need to work around this somehow in elementary in the future?

It will need prioritization, yes. I don't know of any work in this area, one thing that could be done is renaming the portal file to something different, e.g. elementary-settings-daemon.portal.

Secondly, am I correct that the work required in Granite to have it read from here is essentially a D-Bus call to org.freedesktop.portal.Settings Read?

Correct - GTK does the same for GtkSettings. There's already a PR though: elementary/granite#529

WhyNotHugo · 2022-02-15T20:18:50Z

Hi all.

From reading above, it sounds like the GTK and GNOME portals take precedence over this elementary portal based on the current code in xdg-desktop-portal.

This is being a problem for me too on a separate situation (flatpak/xdg-desktop-portal#710). AFAIK, it's a bug on xdg-desktop-portal, right? Do you have any further insight onto it, or is it simple a non-issue for your usage?

alice-mkh · 2022-02-15T20:43:58Z

The priority is decided based on the name (and portals are filtered based on your session, GTK one just loads everywhere), so just name your portal so it comes before others.

alice-mkh mentioned this pull request Sep 19, 2021

settings: Add color-scheme key flatpak/xdg-desktop-portal#633

Merged

alice-mkh commented Sep 19, 2021

View reviewed changes

alice-mkh force-pushed the wip/exalm/portal branch 2 times, most recently from 0929da6 to e132254 Compare September 19, 2021 21:57

Implement the settings portal

e132254

Thankfully, we don't have to implement everything - settings portal can have multiple implementations and will combine settings from all of them. Fixes elementary#37

Marukesu reviewed Sep 19, 2021

View reviewed changes

Address review

a0ef5a1

danirabbit requested a review from Marukesu September 20, 2021 17:04

alice-mkh commented Sep 20, 2021

View reviewed changes

settings-portal/Settings.vala Outdated Show resolved Hide resolved

Marukesu approved these changes Sep 21, 2021

View reviewed changes

Marukesu mentioned this pull request Sep 21, 2021

Support the settings portal where is possible elementary/granite#529

Merged

alice-mkh added 2 commits September 22, 2021 10:03

Address review

94a4e42

Commit what hadn't been committed.

7bbf77e

alice-mkh commented Sep 24, 2021

View reviewed changes

settings-portal/meson.build Outdated Show resolved Hide resolved

alice-mkh commented Sep 24, 2021

View reviewed changes

settings-portal/Settings.vala Show resolved Hide resolved

alice-mkh and others added 3 commits September 30, 2021 09:36

Remove the leftover posix dep

8c75e0e

Merge branch 'master' into wip/exalm/portal

1c9ee57

Update Main.vala

1ecc562

davidmhewitt requested changes Oct 6, 2021

View reviewed changes

settings-portal/Main.vala Outdated Show resolved Hide resolved

Fix version

2cdbd52

davidmhewitt approved these changes Oct 6, 2021

View reviewed changes

danirabbit merged commit b364954 into elementary:master Oct 6, 2021

Marukesu mentioned this pull request Oct 6, 2021

implement settings portal elementary/portals#7

Closed

carnage-mode mentioned this pull request Oct 9, 2021

[Feature Request] org.freedesktop.appearance.color-scheme support to read dark mode preference telegramdesktop/tdesktop#17061

Closed

bobby285271 mentioned this pull request Oct 26, 2021

Pantheon updates 2021-10-25, 2021-10-26 NixOS/nixpkgs#142810

Merged

12 tasks

This was referenced Feb 12, 2022

Support linux system theme JetBrains/skiko#491

Merged

Implement Theme HumbleUI/JWM#161

Open

WhyNotHugo mentioned this pull request Feb 15, 2022

Wrong portal is used for org.freedesktop.portal.Settings flatpak/xdg-desktop-portal#710

Closed

mirkobrombin mentioned this pull request Apr 11, 2024

[bug] Tauri does not detect system theme preference on Linux tauri-apps/tauri#9427

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement the settings portal #38

Implement the settings portal #38

alice-mkh commented Sep 19, 2021

alice-mkh left a comment

alice-mkh Sep 19, 2021

alice-mkh Sep 22, 2021

alice-mkh Sep 22, 2021

danirabbit commented Sep 19, 2021

Marukesu left a comment

Marukesu left a comment

alice-mkh commented Sep 21, 2021

GeorgesStavracas commented Sep 22, 2021

alice-mkh commented Sep 22, 2021

GeorgesStavracas commented Sep 22, 2021

davidmhewitt left a comment

alice-mkh commented Oct 6, 2021

WhyNotHugo commented Feb 15, 2022

alice-mkh commented Feb 15, 2022

Implement the settings portal #38

Implement the settings portal #38

Conversation

alice-mkh commented Sep 19, 2021

alice-mkh left a comment

Choose a reason for hiding this comment

alice-mkh Sep 19, 2021

Choose a reason for hiding this comment

alice-mkh Sep 22, 2021

Choose a reason for hiding this comment

alice-mkh Sep 22, 2021

Choose a reason for hiding this comment

danirabbit commented Sep 19, 2021

Marukesu left a comment

Choose a reason for hiding this comment

Marukesu left a comment

Choose a reason for hiding this comment

alice-mkh commented Sep 21, 2021

GeorgesStavracas commented Sep 22, 2021

alice-mkh commented Sep 22, 2021

GeorgesStavracas commented Sep 22, 2021

davidmhewitt left a comment

Choose a reason for hiding this comment

alice-mkh commented Oct 6, 2021

WhyNotHugo commented Feb 15, 2022

alice-mkh commented Feb 15, 2022