-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings: Add color-scheme key #633
Conversation
64585e7
to
408ce40
Compare
Specify a key for getting the system's preferred color scheme. Fixes flatpak#629
Looks fine to merge once implementations exist. |
https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/12 Do we need an equivalent |
elementary implementation: elementary/settings-daemon#38 |
I'll leave the -gtk question to @GeorgesStavracas |
I would say, yes. |
See flatpak/xdg-desktop-portal#633 (comment) The equivalent xdg-desktop-portal-gnome change: https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/12
|
See flatpak/xdg-desktop-portal#633 (comment) The equivalent xdg-desktop-portal-gnome change: https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/12
Implement flatpak/xdg-desktop-portal#633 Currently only maps schemes from the breeze family to light/dark and returns no preference for third-party schemes A fancier solution for the future would be to try and guess whether a scheme is light or dark like the colors KCM does
Implement flatpak/xdg-desktop-portal#633 Currently only maps schemes from the breeze family to light/dark and returns no preference for third-party schemes A fancier solution for the future would be to try and guess whether a scheme is light or dark like the colors KCM does
@Exalm, @GeorgesStavracas, @TingPing |
We have it in GNOME, but I consider it a separate issue when it comes to having a standardized one - for example, elementary doesn't have it. |
GNOME has a separate accessibility toggle with no dedicated D-Bus connection to listen on, for apps to handle it(and missing documentation). |
I mean until recently (still is in 41) it was a theme - not even a flag. One thing at a time :p |
Implement flatpak/xdg-desktop-portal#633 Currently only maps schemes from the breeze family to light/dark and returns no preference for third-party schemes A fancier solution for the future would be to try and guess whether a scheme is light or dark like the colors KCM does
I'm trying to read this setting with non-flatpak'd apps (in my case, d-feet), but I get:
Are native applications supposed to use a different mechanism to retrieve this value from the portal? |
IMO no, if it's not working for some reason that's a bug. |
Fedora Linux 35; Workstation/GNOME; xdg-desktop-portal-gnome/xdg-desktop-portal-gtk; d-feet via dnf; Works:
|
@rusty-snake Reported in #737 |
Specify a key for getting the system's preferred color scheme.
Fixes #629