Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial switch position #103

Closed
wants to merge 1 commit into from
Closed

Conversation

leolost2605
Copy link
Member

Currently when launching the switches are in the wrong position compared to their state for options that are toggled on.

@leolost2605 leolost2605 requested a review from a team March 21, 2024 21:50
@danirabbit

This comment was marked as resolved.

@danirabbit
Copy link
Member

Or actually, why is that binding to state instead of active?

@leolost2605
Copy link
Member Author

The docs say state should represent the underlying well "state" of the backend and it's represented by the color whereas active is represented by the switch position and should respond immediately to user input.
active should be bound to state by the default signal handler for state_set but that doesn't seem to work for setting it the first time.

Are we sure we don't just need to add sync create here? https://github.com/elementary/switchboard-plug-notifications/blob/main/src/Widgets/AppSettingsView.vala

AFAIK setting bindings are sync create by default (it's not even an available flag)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants