Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppSettingsView: Fix initial switch toggle position #104

Merged
merged 1 commit into from
Mar 22, 2024
Merged

AppSettingsView: Fix initial switch toggle position #104

merged 1 commit into from
Mar 22, 2024

Conversation

danirabbit
Copy link
Member

Closes #103

@danirabbit
Copy link
Member Author

@leolost2605 what do you think about this instead? A little more invasive, but it feels janky to me to bind switch properties to themelves 😬

leolost2605
leolost2605 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure let's go with this :)

@danirabbit danirabbit merged commit 503d0fc into main Mar 22, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/switch-position branch March 22, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leolost2605 leolost2605 leolost2605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @leolost2605