Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Granite.SettingsSidebar #165

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Use Granite.SettingsSidebar #165

merged 3 commits into from
Jan 3, 2024

Conversation

danirabbit
Copy link
Member

Use Granite's SettingsSidebar instead of a custom sidebar implementation

@danirabbit danirabbit requested a review from a team January 1, 2024 21:51
@danirabbit danirabbit mentioned this pull request Jan 1, 2024
Merged
jeremypw
jeremypw approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and no change in behaviour found.

@jeremypw jeremypw merged commit 33dad1c into master Jan 3, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/settingssidebar branch January 3, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw