Fix figures panel not showing when none of the figures has a paragraph. #223
Conversation
|
Re issue #221 |
|
The result is looking good when I test with eLife article Thanks for preparing the PR here @DavidMorenoCortina! I have a question I'll add an inline comment for. |
| @@ -136,6 +136,10 @@ Container.Prototype = function() { | |||
| return this.listView.length; | |||
| }; | |||
|
|
|||
| this.hasContent = function(panelType) { | |||
There was a problem hiding this comment.
@DavidMorenoCortina, I'm wondering in what situation panelType is used here, because if I remove it and change the code below, it gives the same effect for eLife articles. Is it a hook used elsewhere in other Lens implementations?
There was a problem hiding this comment.
@gnott I used panelType in case other panel types are added and their content only have to be shown based on listView. At this moment that check is redundant because all panels are resource type so it could be simplified
| this.hideToggle(); | ||
| this.hide(); | ||
| } else { | ||
| if (this.getContainer().hasContent(this.config.type)) { |
There was a problem hiding this comment.
@gnott I've added "this.config.type" to the PR, I missed it when did the fork, sorry.
There was a problem hiding this comment.
That fills in the missing part, thanks for this @DavidMorenoCortina!
Figures panel doesn't show when the figures hasn't caption or the captions hasn't a paragraph. So when the panel is of "resource" type it should check if the treeView has nodes.