Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update TES models to v1.1 #179

Merged
merged 9 commits into from
Jul 22, 2024
Merged

feat: update TES models to v1.1 #179

merged 9 commits into from
Jul 22, 2024

Conversation

athith-g
Copy link
Contributor

@athith-g athith-g commented Jun 21, 2024

Details

Added fields that were added in TES v1.1 to models.py

TES v1.1 changes:

  • Proposal: add "backend_parameters" to tesResources
  • Added here
  • Add in new tesState for preempted state
  • Added here
  • feat: allow wildcards in output paths
  • NOT added. It seems like this is being reverted in Remove path_prefix from TES specification ga4gh/task-execution-schemas#195
  • Making file type an optional argument
  • Added here
  • Changing int64 to int32 for page_size and cpu_count
  • Not in models.py
  • Adding ignore_error flag
  • Added here
  • Add CANCELING state to delete cloud resources
  • Added here
  • Adding streamable flag to tesInput
  • Added here
  • Adding filtering features to task listing
  • Not in models.py

I removed the unnecessary newlines but I'm not sure how to achieve the whitespacing in the existing descriptions.

Summary by Sourcery

Updated TES models to v1.1 by adding new fields and states to support the latest features and configurations as per the TES v1.1 specification.

  • New Features:
    • Added 'ignore_error' field to TesExecutor to allow continuation on errors.
    • Made 'type' field in TesInput and TesOutput optional with a default value of 'FILE'.
    • Added 'streamable' flag to TesInput to indicate potential use of streaming interfaces.
    • Introduced 'backend_parameters' and 'backend_parameters_strict' fields to TesResources for backend configuration.
    • Added 'PREEMPTED' and 'CANCELING' states to TesState.

Copy link

sourcery-ai bot commented Jun 21, 2024

Reviewer's Guide by Sourcery

This pull request updates the TES models to version 1.1 by adding new fields and modifying existing ones in models.py. The changes include adding new fields such as ignore_error, streamable, backend_parameters, and backend_parameters_strict, making the type field optional in TesInput and TesOutput, and adding new states PREEMPTED and CANCELING to TesState.

File-Level Changes

Files Changes
pro_tes/ga4gh/tes/models.py Updated TES models to version 1.1 by adding new fields and modifying existing ones to align with the latest TES schema changes.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @athith-g - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

pro_tes/ga4gh/tes/models.py Outdated Show resolved Hide resolved
pro_tes/ga4gh/tes/models.py Show resolved Hide resolved
pro_tes/ga4gh/tes/models.py Outdated Show resolved Hide resolved
pro_tes/ga4gh/tes/models.py Show resolved Hide resolved
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, the one open Sourcery AI comment looks reasonable - although I have no clue if their suggested change works. Maybe you can try it out and either replace or comment on why it didn't work

@uniqueg
Copy link
Member

uniqueg commented Jul 2, 2024

Also - tests fail...

@athith-g
Copy link
Contributor Author

athith-g commented Jul 9, 2024

I think the rest of the linting and integration tests will pass once #178 is merged.

@uniqueg
Copy link
Member

uniqueg commented Jul 22, 2024

LGTM, @athith-g - I think you can merge :)

@athith-g athith-g merged commit 1331fea into dev Jul 22, 2024
5 checks passed
@athith-g athith-g deleted the update_tes_models branch July 22, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants