Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code is included in production builds #108

Closed
ctcpip opened this issue Sep 14, 2018 · 6 comments
Closed

code is included in production builds #108

ctcpip opened this issue Sep 14, 2018 · 6 comments
Assignees
@drewlee

Comments

@ctcpip
Copy link
Contributor

ctcpip commented Sep 14, 2018

Is it possible to exclude this code from being included when running ember b --environment=production ?
@rwjblue
Copy link
Member

rwjblue commented Sep 14, 2018

Hmm, that should already be the default behavior...

@ctcpip
Copy link
Contributor Author

ctcpip commented Sep 14, 2018

"should" being the key word there :)

screen shot 2018-09-14 at 3 03 13 pm

@rwjblue
Copy link
Member

rwjblue commented Sep 14, 2018

D'oh! Looks like we need this kind of thing for treeForAddon...

@ctcpip
Copy link
Contributor Author

ctcpip commented Sep 14, 2018 •
edited
Loading 

"addon-tree-output/ember-a11y-testing/utils/is-background-replaced-element.js":   1264,
"addon-tree-output/ember-a11y-testing/utils/violations-helper.js":   2892,

@drewlee drewlee self-assigned this Sep 26, 2019
drewlee pushed a commit to drewlee/ember-a11y-testing that referenced this issue Sep 27, 2019
Fixes code included in production builds [ember-a11y#108]
522286e
@drewlee
Copy link
Contributor

drewlee commented Sep 27, 2019

I have a fix for this in PR #134

drewlee pushed a commit to drewlee/ember-a11y-testing that referenced this issue Sep 27, 2019
Fixes code included in production builds [ember-a11y#108]
c9b02b5
drewlee pushed a commit to drewlee/ember-a11y-testing that referenced this issue Sep 27, 2019
Fixes code included in production builds [ember-a11y#108]
0c78ded
drewlee pushed a commit that referenced this issue Sep 27, 2019
Fixes code included in production builds [#108] (#134)
b671586
@drewlee
Copy link
Contributor

drewlee commented Sep 27, 2019

Fixed w/PR #134. Will publish a new release sometime before Monday.

@drewlee drewlee closed this as completed Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewlee drewlee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwjblue @drewlee @ctcpip