Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes code included in production builds [#108] #134

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Fixes code included in production builds [#108] #134

merged 1 commit into from
Sep 27, 2019

Conversation

drewlee
Copy link
Contributor

@drewlee drewlee commented Sep 27, 2019 •
edited
Loading

Adds override to exclude all addon related code from production builds.

Makes axe check a bit more defensive.

  • We recently ran into an issue where the axe-component initializer was getting bundled with a bunch of engines, causing exceptions by calling axe where it didn't exist. Although this was ultimately a build issue not related to the addon, the failure can definitely be made much more graceful.

@drewlee drewlee mentioned this pull request Sep 27, 2019
Closed
rwjblue
rwjblue reviewed Sep 27, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
@drewlee drewlee merged commit b671586 into ember-a11y:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewlee @rwjblue