Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ember-cli-update to v3.28.2 and make Ember v4 scenarios pass #726

Closed
wants to merge 1 commit into from
Closed

Run ember-cli-update to v3.28.2 and make Ember v4 scenarios pass #726

wants to merge 1 commit into from

Conversation

SergeAstapov
Copy link
Contributor

@SergeAstapov SergeAstapov commented Oct 13, 2021

This is similar to #720 by @ndekeister-us except that this PR upgrades to 3.28.2 and CI is green

This is BREAKING change as it requires the consuming app or an addon to have ember-auto-import v2.
This is prerequisite for Ember v4 upgrade for the apps. ember-auto-import v2 upgrade landed in #739.

@SergeAstapov SergeAstapov changed the title Run ember-cli-update to v3.28.2 Run ember-cli-update to v3.28.2 and update ember-auto-import to v2 Oct 15, 2021
@SergeAstapov SergeAstapov changed the title Run ember-cli-update to v3.28.2 and update ember-auto-import to v2 Run ember-cli-update to v3.28.3 and make Ember v4 scenarios pass Oct 21, 2021
@SergeAstapov
Copy link
Contributor Author

SergeAstapov commented Oct 21, 2021

@Turbo87 this PR was reduced in size and non-essential changes to tests syntax (angle bracket component invocation and ember-template-link v3 upgrade) as well as introduction of eslint-plugin-qunit (per recent Ember CLI blueprint) moved to #742.

@SergeAstapov SergeAstapov changed the title Run ember-cli-update to v3.28.3 and make Ember v4 scenarios pass Run ember-cli-update to v3.28.2 and make Ember v4 scenarios pass Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant