Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Enable Ember v4 scenarios again #740

Merged
merged 1 commit into from
Dec 11, 2021
Merged

CI: Enable Ember v4 scenarios again #740

merged 1 commit into from
Dec 11, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 21, 2021

#739 should have fixed the issue.

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 21, 2021

well... looks like liquid-fire is still giving us trouble 🙈

@SergeAstapov
Copy link
Contributor

SergeAstapov commented Oct 21, 2021 •
edited
Loading

@Turbo87 this got fixed in #726 😜

EDIT: there is smaller PR #747 which the minimum amount of changes needed to make CI pass.

@SergeAstapov
Copy link
Contributor

Update:
#746 and #747 need to land first as they update transitive dependencies that causes failures in this PR.

@Turbo87 Turbo87 merged commit c0568fb into ember-cli:master Dec 11, 2021
@Turbo87 Turbo87 deleted the ember-4 branch December 11, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @SergeAstapov