Upgrade ember-cli-addon-docs and enable Ember v4 scenarios #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
commented
Oct 24, 2021
| @@ -37,6 +37,7 @@ module.exports = async function () { | |||
| name: 'ember-lts-3.12', | |||
| npm: { | |||
| devDependencies: { | |||
| 'ember-cli': '~3.12.0', | |||
There was a problem hiding this comment.
With latest Ember CLI there is a build time error originated from ember-cli-addon-docs
| @@ -78,6 +79,7 @@ module.exports = async function () { | |||
| npm: { | |||
| devDependencies: { | |||
| 'ember-source': await getChannelURL('beta'), | |||
| 'ember-template-lint': '^3.10.0', | |||
There was a problem hiding this comment.
with ember-template-lint@2 there is build time error in beta scenario
| @@ -43,7 +43,7 @@ | |||
| "cli-table3": "^0.6.0", | |||
| "debug": "^4.2.0", | |||
| "ember-auto-import": "^2.2.3", | |||
| "ember-cli-babel": "^7.21.0", | |||
| "ember-cli-babel": "^7.26.6", | |||
There was a problem hiding this comment.
This fixes build time warning about old ember-cli-babel version
| @@ -61,8 +61,8 @@ | |||
| "babel-eslint": "^10.1.0", | |||
| "codeclimate-test-reporter": "^0.5.0", | |||
| "ember-cli": "^3.28.3", | |||
| "ember-cli-addon-docs": "^0.10.0", | |||
| "ember-cli-addon-docs-yuidoc": "^0.2.4", | |||
| "ember-cli-addon-docs": "^4.0.3", | |||
There was a problem hiding this comment.
had to be upgraded to make CI pass with Ember v4 beta/canary (there is bunch if fixes in transitive dependencies)
|
this was done in #768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.