Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not find module rsvp imported from fetch #622

Closed
mydea opened this issue Jun 10, 2021 · 6 comments · Fixed by #623
Closed

Could not find module rsvp imported from fetch #622

mydea opened this issue Jun 10, 2021 · 6 comments · Fixed by #623

Comments

@mydea
Copy link
Contributor

mydea commented Jun 10, 2021

When trying to setup embroider for our app, I get this error:

Uncaught Error: Could not find module `rsvp` imported from `fetch`

I tried to also install rsvp (yarn add rsvp --dev) in my app but it didn't help.

@rwjblue
Copy link
Member

rwjblue commented Jun 10, 2021

@mydea - What ember-source version?

@mydea
Copy link
Contributor Author

mydea commented Jun 10, 2021

ember-source@3.27.3, and Embroider at 0.41.0.

@mydea
Copy link
Contributor Author

mydea commented Jun 10, 2021

I played around with it a bit, trying to make it recognize rsvp, but couldn't get it to work. I ended up with this kind of workaround (which is decent I'd say, but also rather circumvents the problem) here: #623

@rwjblue
Copy link
Member

rwjblue commented Jun 11, 2021

Hmm, Embroider should be able to resolve rsvp module if imported directly. I wonder which of the compat flags you have setup? If you have most of the strictnesss / compat flags setup, I'd bet that the issue is that this isn't a "real" module (we are defining an AMD module) so it doesn't get replaced by the webpack require mechanism (and with strictness setup, we don't eagerly define all the modules for compatibility purposes anymore).

@mydea
Copy link
Contributor Author

mydea commented Jun 14, 2021

It happens once I switch staticAddonTrees on!

@SergeAstapov
Copy link
Contributor

SergeAstapov commented Aug 23, 2022

For history, probably related to embroider-build/embroider#1195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants