Allow to use native promises instead of RSVP #623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially tried to get it to work with using
require('rsvp')
when building with Embroider.However, I couldn't get it to run. I tried adding
rsvp
as a dedicated dependency, as well asember-auto-import
, and importing RSVP in an initializer, but nothing made it available underrequire('rsvp')
in my embroider app.I ended up adding an option that allows to opt out of using the RSVP wrapper at all. I think this is an acceptable and backwards compatible opt-out option that should be OK for apps that target only browsers that do not target IE11 anymore.
Let me know if you think this works, or if a different approach would work better.
Closes #622