Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to see what is blocking while doing the whole conversion in one go
Pending
upstream patchesThings preserved:
Breaking changes:
setResolver
assetApplication
already sets up an event-dispatcher, and for complexity reasons, support for custom event dispatcher has been removed increateCustomResolver
Non-Breaking changes:
once all core ember addons are v2, we can much more easily do vite/vitest tests in non-monorepo repos (lots of cool things are unlocked once we drop broccoli / v1 addons entirely -- single-repos become an option again!).