V2 Addon Conversion #1471
V2 Addon Conversion #1471
Conversation
| // @ts-ignore | ||
| import { precompileTemplate } from '@ember/template-compilation'; | ||
|
|
||
| const OUTLET_TEMPLATE = precompileTemplate(`{{outlet}}`, { strictMode: false }); |
There was a problem hiding this comment.
I didn't want to import from ember-cli-htmlbars, so I used @ember/template-compilation for precompileTemplate
There was a problem hiding this comment.
This could also be pulled out to a separate PR, if folks want
| // here; also see https://github.com/emberjs/data/issues/4071 for context | ||
| let setupContainer = require('ember-data/setup-container')['default']; | ||
| setupContainer(owner); | ||
| if (macroCondition(dependencySatisfies('ember-data', '>= 2.3'))) { |
There was a problem hiding this comment.
This change is also meaningful -- we don't want to use requirejs -- we're trying to get rid of it.
Insetad, our abstraction over runtime module loader is provided by embroider-macros.
Additionally, I saw that in this file that setup-container is deprecated without replacement for removal in v6.
So I added another if condition around this code so we can hopefully be a little fault tolerant when ember-data v6 comes around.
There was a problem hiding this comment.
This could also be pulled out to a separate PR, if folks want
NullVoxPopuli
force-pushed
the
the-v2-addon-conversion
branch
2 times, most recently
from
6366b0d to
fa96de8
Compare
NullVoxPopuli
force-pushed
the
the-v2-addon-conversion
branch
from
6d7e763 to
3c062f6
Compare
NullVoxPopuli
force-pushed
the
the-v2-addon-conversion
branch
from
3c062f6 to
d62c5cf
Compare
It doesn't make sense to run tests for type-tests with ember-try, since they're in a different workspace and not using the app Remove Glint
Need multi-lockfile thanks to TS
Fix docs command
NullVoxPopuli
force-pushed
the
the-v2-addon-conversion
branch
from
d62c5cf to
c25dacf
Compare
PRs to extract:
Drop support for TS < 5 #1474
requireRemove require usage, dropping support for automatic ember-data/setup-container inclusion #1472
Add Docs-Generation to CI -- will error if docs get out of sync and provides actionable information towards resolution. #1477
.npmrcUse strict .npmrc #1475
pnpm-lock.yaml(for more robust testing with both@types/*and built-in types)Don't use a shared lockfile #1476
Steps:
cd addonnpx ember-cli@latest init --blueprint @embroider/addon-blueprint --typescript --addon-onlypnpm lint:fix