Move tests to new test-app #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
extract-test-app
branch
from
ae81352 to
b9443ae
Compare
NullVoxPopuli
commented
Jul 24, 2024
| @@ -35,19 +38,6 @@ QUnit.done(function () { | |||
| } | |||
| }); | |||
|
|
|||
| class TestLoader extends AbstractTestLoader { | |||
There was a problem hiding this comment.
handled by ember-qunit these days
NullVoxPopuli
commented
Jul 24, 2024
| @@ -109,8 +99,8 @@ QUnit.assert.deprecationsInclude = function (expected) { | |||
| }); | |||
| }; | |||
|
|
|||
| QUnit.start(); | |||
|
|
|||
| if (typeof Testem !== 'undefined') { | |||
There was a problem hiding this comment.
also handled by ember-qunit
NullVoxPopuli
force-pushed
the
extract-test-app
branch
from
e061c70 to
23aa201
Compare
…urce, and declares a peerDependency, we must use depMeta*injected
NullVoxPopuli
force-pushed
the
extract-test-app
branch
from
fb6af49 to
f84c442
Compare
lifeart
reviewed
Jul 26, 2024
lifeart
reviewed
Jul 26, 2024
| "node": "14.* || 16.* || >= 18" | ||
| }, | ||
| "ember": { | ||
| "edition": "octane" |
lifeart
reviewed
Jul 26, 2024
| "webpack": "^5.78.0" | ||
| }, | ||
| "engines": { | ||
| "node": "14.* || 16.* || >= 18" |
There was a problem hiding this comment.
wondering if we could drop 14 and 16..
There was a problem hiding this comment.
We could, but would me separate. During v2 conversion, node would cease to matter anyway
kategengler
approved these changes
Jul 29, 2024
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2 addons don't have an integrated test setup atm, so a separate test app is how we test v2 addons.
Test-helpers isn't a v2 addon yet, but this'll greatly reduce the diff of that upcoming change.
This is a non-breaking change as it mostly focuses on using a new app for the tests instead of using the "dummy app"
For V2 Conversion
depending on how these PRs go will determine if we need to do a major or not.