[GLIMMER] Ensure objects with .forEach can be iterated.
#13904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -175,6 +175,12 @@ class Iterable { | |||
| return new EmberArrayIterator(iterable, keyFor); | |||
| } else if (Array.isArray(iterable)) { | |||
| return iterable.length > 0 ? new ArrayIterator(iterable, keyFor) : EMPTY_ITERATOR; | |||
| } else if (iterable.forEach !== undefined) { | |||
There was a problem hiding this comment.
Is it better to test for typeof iterable.forEach === "function"?
There was a problem hiding this comment.
Unsure, but that seems fine too. I will change it.
rwjblue
force-pushed
the
enable-for-each-objects
branch
from
077a872
to
6659dc3
Compare
| iterable.forEach(function(item) { | ||
| array.push(item); | ||
| }); | ||
| return array.length > 0 ? new ArrayIterator(array, keyFor) : EMPTY_ITERATOR; | ||
| } else if (isEachIn(ref)) { |
There was a problem hiding this comment.
isEachIn probably needs to be moved up – if you do {{#each-in someArray ...}} for some reason, it should do what you asked for instead of looping through the array. It's largely unrelated to what you are doing here because even if you move it above your branch it will still be a problem, but we should remember to fix it and add a test.
There was a problem hiding this comment.
Sounds good, I'll follow up with that in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was supported (though untested) in HTMLBars. Added some tests and implemented in Glimmer.