each-in: Iterate over array by keys, not by elements #13915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add the INUR steps? (Search for the "Pls send halp" issue) |
| this.render(strip` | ||
| {{#each-in arr as |key value|}} | ||
| [{{key}}:{{value}}] | ||
| {{/each-in}}`, { arr: [] }); |
There was a problem hiding this comment.
Normally, you want to put the target test case first, so I would start with { arr } instead.
each-in: Iterate over array by keys, not by elements each-in: Iterate over array by keys, not by elements each-in: Iterate over array by keys, not by elements each-in: Iterate over array by keys, not by elements each-in: Iterate over array by keys, not by elements
|
This looks good to me. I'll let @chancancode do a last review pass to make sure the various things he mentioned are good to go... |
chancancode
added a commit
that referenced
this pull request
Jul 27, 2016
each-in: Iterate over array by keys, not by elements
chancancode
added a commit
that referenced
this pull request
Jul 27, 2016
Merge #13915 and cleanup each-in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.