Upgrade addon to eslint 8 #108
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| singleQuote: true, | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| <% } %> "plugins": [<% if (typescript) { %> | ||
| ["@babel/plugin-transform-typescript", { "allowDeclareFields": true }],<% } %> | ||
| "@embroider/addon-dev/template-colocation-plugin", | ||
| ["@babel/plugin-proposal-decorators", { "decoratorsBeforeExport": true }], | ||
|
There was a problem hiding this comment. @void-mAlex @NullVoxPopuli When setting Some tests for the docs and test apps for # One type of error
Error: Assertion Failed: The options object passed to tracked() may only contain a 'value' or 'initializer' property, not both. Received: [kind,key,placement,descriptor,ini
# Another type
ReferenceError: Cannot access 'ContainerQueryComponent' before initialization
# And another
TypeError: An element descriptor's .kind property must be either "method" or "field", but a decorator created an element descriptor with .kind "undefined"I couldn't find examples of other addons that currently use https://emberobserver.com/code-search?codeQuery=decoratorsBeforeExport&fileFilter=babel There was a problem hiding this comment. ah, this was probably a mistake, we should bring to There was a problem hiding this comment. Yes, I will create a PR, thanks for the quick feedback. |
||
| "@babel/plugin-proposal-class-properties" | ||
| ] | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about
*.cjs?and
.prettierrc.jsshould be cjs, tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, I suppose, this is how I made my "One lint config" for all apps, addons, v2 addons: https://github.com/NullVoxPopuli/eslint-configs/blob/main/configs/ember.js#L12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only the files that I've touched here are delivered from this repo (eg https://github.com/embroider-build/addon-blueprint/blob/main/files/__addonLocation__/.eslintrc.cjs), the rest seem to be from the base addon
as far as I've generated the addon with this command it creates a
.prettierrc.jsand not a .cjs file hence I've left that as isthe changes here are correct as for the output of this blueprint (to the best of my ability to verify)
not sure what if anything you expect to be different here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just that if we throw type=module in the package.json, the prettier file will be required to be cjs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are regex's so how about I make all options valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you mean? All the 'node files' should be .cjs, and then this eslint entry can be
*.cjsinstead of the 4 or 5 lines it is now. But, i think bucause all our browser code is in src, we could probably safely assume all*.{cjs,js}are node. The toplevel cjs in def node, and the top level js would be esm. One eslint entry to rule them all! (Of the package root lol)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(tho, because parserType is 'script', only cjs is supported atm -- kinda obnoxious that esm and cjs need different parsers.)