importSync breaks the builds of apps consuming type=module packages

[NullVoxPopuli]

repro:

• create a v2 addon
• add type=module to the package's package.json
• add a src/example.css file
• add code to src/index.js

  import { importSync } from '@embroider/macros';
  
  export const two = 2;
  
  importSync('./example.css');

  Note, in my actual project, importSync is wrapped in a macroCondition.
  if it were not wrapped in a macroCondition I would just use regular import './example.css';
• build the addon
• change the test-app ember-cli-build.js to directly use embroider (compat or strict doesn't matter):

  const { Webpack } = require('@embroider/webpack');
  return require('@embroider/compat').compatBuild(app, Webpack, {
    skipBabel: [
      {
         package: 'qunit',
      },
    ],
  });

• start the app
• receive error

  Module not found: Error: Can't resolve '../../node_modules/.pnpm/@embroider+macros@1.13.3/node_modules/@embroider/macros/src/addon/es-compat2' in '/home/nvp/Development$TMPDIR/type-module-test/type-module-test/dist/index.js'
  Did you mean 'es-compat2.js'?
  BREAKING CHANGE: The request '../../node_modules/.pnpm/@embroider+macros@1.13.3/node_modules/@embroider/macros/src/addon/es-compat2' failed to resolve only because it was resolved as fully specified
  (probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
  The extension in the request is mandatory for it to be fully specified.
  Add the extension to the request.

To see that type=module appears to work:

• remove importSync
• rebuild addon
• restart app

Here is a PR proving the above in a real addon: universal-ember/ember-primitives#33

[mansona]

is this still a problem with #1692 ?