force importSync to always be eager #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
force-eager-import-sync
branch
3 times, most recently
from
d021b4c to
064f5e8
Compare
mansona
force-pushed
the
force-eager-import-sync
branch
from
064f5e8 to
dbe3bda
Compare
The addon was referring to its own dummy app. Now that modules are getting eagerly evaluated this becomes a failure except inside the dummy app.
|
I ultimately had to drop all of ember-data < 5 from the test coverage, so as it stands that is part of the breaking change. We can separately assess whether / how we can restore some of that support with new compat adapters. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.