Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bright text is too faint/weak #1410

Closed
emilk opened this issue Mar 23, 2022 · 0 comments · Fixed by #1412 or #2071
Closed

Bright text is too faint/weak #1410

emilk opened this issue Mar 23, 2022 · 0 comments · Fixed by #1412 or #2071
Labels
bug Something is broken

Comments

@emilk
Copy link
Owner

emilk commented Mar 23, 2022

Compare white text on black with black text on white:

Screen Shot 2022-03-23 at 13 40 08 Screen Shot 2022-03-23 at 13 40 13

Even though the text colors are #fffff and #00000 they do not appear as such. ab_glyph computes per-pixel coverage values, and no pixels in the text are fully covered by the glyph. This makes the text looks a bit too faint in both cases.

This problem is much more pronounced on the bright text. The effect of this is that the bright text looks fainter, thinner and weaker than the black text. This just makes bright mode worse overall in egui.

It is possible this could be solved by either by switching to gamma-blending, or by tweaking how we interpret/store the coverage values we get from ab_glyph.

@emilk emilk added the bug Something is broken label Mar 23, 2022
emilk added a commit that referenced this issue Mar 23, 2022
This is an experiment to investigate solutions to
* #1410
emilk added a commit that referenced this issue Apr 5, 2022
This is an experiment to investigate solutions to
* #1410
emilk added a commit that referenced this issue Jul 3, 2022
This is an experiment to investigate solutions to
* #1410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
1 participant