Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not detecting mouse release after alt-tab on windows #4418

Closed
nickd-airo opened this issue Apr 26, 2024 · 0 comments · Fixed by #4419
Closed

Not detecting mouse release after alt-tab on windows #4418

nickd-airo opened this issue Apr 26, 2024 · 0 comments · Fixed by #4419
Labels
bug Something is broken

Comments

@nickd-airo
Copy link

Environment

App: egui_demo_app (+ other egui-based apps)
OS: Windows 11
Git: 0bc59f5

Describe the bug

  1. Open the 'input test' demo.
  2. Click and hold Sense::drag
  3. Move cursor off egui window
  4. Alt-tab to a different window
  5. Release mouse
  6. Alt-tab back to egui window
  7. Move cursor around
  8. Mouse is erroneously considered pressed, even though it was released
  9. Click mouse on egui window to fix state

Expected

Mouse should be detected as released once it is released. Other native windows apps seem to do this correctly, e.g. ms paint.
@nickd-airo nickd-airo added the bug Something is broken label Apr 26, 2024
@rustbasic rustbasic mentioned this issue Apr 26, 2024
Merged
emilk pushed a commit that referenced this issue May 11, 2024
@rustbasic
Treat Event::PointerGone as PointerEvent::Released (#4419)
66d2b3f 
* Closes #4406
* Closes #4418 

If `Event::PointerGone` occurs, it is treated as
`PointerEvent::Released`.
@emilk emilk mentioned this issue May 21, 2024
Merged
emilk added a commit that referenced this issue May 22, 2024
@emilk
Fix: still track mouse when dragging outside web canvas (#4522)
c8578c9 
* Closes #3157

If the mouse leaves the canvas when dragging a slider, the slider will
still move.

---

To support this, I had to revert #4419
Despite that, I fail to reproduce the two issues it claimed to solve:

* #4406 may have been solved in
another way by this PR
* #4418 I cannot reproduce on Mac.
If it is still a problem, I think it should be solved by triggering a
`PointerEvent::Released` when focus is lost (i.e. on alt-tab), and not
on `PointerGone`
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@rustbasic @hacknus
Treat Event::PointerGone as PointerEvent::Released (emilk#4419)
c45faf6 
* Closes emilk#4406
* Closes emilk#4418 

If `Event::PointerGone` occurs, it is treated as
`PointerEvent::Released`.
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@emilk @hacknus
Fix: still track mouse when dragging outside web canvas (emilk#4522)
6bf0b0e 
* Closes emilk#3157

If the mouse leaves the canvas when dragging a slider, the slider will
still move.

---

To support this, I had to revert emilk#4419
Despite that, I fail to reproduce the two issues it claimed to solve:

* emilk#4406 may have been solved in
another way by this PR
* emilk#4418 I cannot reproduce on Mac.
If it is still a problem, I think it should be solved by triggering a
`PointerEvent::Released` when focus is lost (i.e. on alt-tab), and not
on `PointerGone`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat Event::PointerGone as PointerEvent::Released rustbasic/egui
1 participant
@nickd-airo