Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: temp dir option #1041

Merged
merged 10 commits into from
Jun 30, 2024
Merged

Feature: temp dir option #1041

merged 10 commits into from
Jun 30, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 23, 2024

No description provided.

@emmercm emmercm self-assigned this Mar 23, 2024
Copy link

github-actions bot commented Mar 23, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/temp-dir-option" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm enabled auto-merge (squash) June 30, 2024 01:27
@emmercm emmercm disabled auto-merge June 30, 2024 01:27
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.13%. Comparing base (eca2260) to head (f03b154).

Files Patch % Lines
src/globals/temp.ts 85.71% 1 Missing ⚠️
src/igir.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1041      +/-   ##
==========================================
+ Coverage   92.81%   93.13%   +0.31%     
==========================================
  Files         104      105       +1     
  Lines        6431     6436       +5     
  Branches     1523     1526       +3     
==========================================
+ Hits         5969     5994      +25     
+ Misses        461      441      -20     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 9245a31 into main Jun 30, 2024
53 of 54 checks passed
@emmercm emmercm deleted the emmercm/temp-dir-option branch June 30, 2024 01:28
@Djabal
Copy link

Djabal commented Jul 14, 2024

Hi,
I have tried to use the --temp-dir option with a tmpfs dir. It seems that igir try to delete the given temp-dir on exit.

node:internal/process/promises:391
triggerUncaughtException(err, true /* fromPromise */);
^

[Error: EBUSY: resource busy or locked, rmdir 'software/igir.temp/'] {
errno: -16,
code: 'EBUSY',
syscall: 'rmdir',
path: 'software/igir.temp/'
}

Node.js v20.15.0

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants