Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: split constants into two classes #1189

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jun 27, 2024

RE: #1041

@emmercm emmercm self-assigned this Jun 27, 2024
@emmercm emmercm enabled auto-merge (squash) June 27, 2024 22:35
Copy link

github-actions bot commented Jun 27, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/split-constants" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.06%. Comparing base (f34f9d4) to head (3e90889).

Files Patch % Lines
src/igir.ts 25.00% 3 Missing ⚠️
src/constants/package.ts 93.33% 1 Missing ⚠️
src/modules/updateChecker.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
- Coverage   93.06%   93.06%   -0.01%     
==========================================
  Files         103      104       +1     
  Lines        6433     6431       -2     
  Branches     1523     1418     -105     
==========================================
- Hits         5987     5985       -2     
- Misses        423      445      +22     
+ Partials       23        1      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 860693d into main Jun 28, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/split-constants branch June 28, 2024 23:02
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant