Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: check for conflicting output file paths #1208

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 11, 2024

Fixes: #1201

@emmercm emmercm self-assigned this Jul 11, 2024
@emmercm emmercm marked this pull request as ready for review July 17, 2024 02:18
@emmercm emmercm enabled auto-merge (squash) July 17, 2024 02:18
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.24%. Comparing base (d02511c) to head (12d29f4).

Files Patch % Lines
src/igir.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
+ Coverage   93.21%   93.24%   +0.02%     
==========================================
  Files         107      108       +1     
  Lines        6649     6689      +40     
  Branches     1570     1579       +9     
==========================================
+ Hits         6198     6237      +39     
- Misses        428      429       +1     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 351c91b into main Jul 17, 2024
52 of 54 checks passed
@emmercm emmercm deleted the emmercm/validate-output-conflicts branch July 17, 2024 02:24
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent file name collision
1 participant