Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove duplicate games when combining DATs #1209

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 11, 2024

RE: #1208

@emmercm emmercm self-assigned this Jul 11, 2024
@emmercm emmercm enabled auto-merge (squash) July 11, 2024 16:01
Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/unique-combine-games" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (7c300db) to head (e76ffb6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1209   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files         105      105           
  Lines        6497     6498    +1     
  Branches     1539     1532    -7     
=======================================
+ Hits         6049     6050    +1     
  Misses        425      425           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 0a212cf into main Jul 11, 2024
55 checks passed
@emmercm emmercm deleted the emmercm/unique-combine-games branch July 11, 2024 16:10
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant