Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: dir2dat use Game and ROM information from candidates #1213

Merged
merged 2 commits into from
Jul 12, 2024

Backport #1174

e722db2
Select commit
Loading
Failed to load commit list.
Merged

Refactor: dir2dat use Game and ROM information from candidates #1213

Backport #1174
e722db2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 12, 2024 in 1s

93.10% (target 94.00%)

View this Pull Request on Codecov

93.10% (target 94.00%)

Details

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.10%. Comparing base (895ce43) to head (e722db2).

Files Patch % Lines
src/types/dats/rom.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   92.85%   93.10%   +0.24%     
==========================================
  Files         105      105              
  Lines        6498     6513      +15     
  Branches     1540     1435     -105     
==========================================
+ Hits         6034     6064      +30     
- Misses        440      448       +8     
+ Partials       24        1      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.