Bump min node version to 18.20.3 #22010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
dump_default_node_min_version
branch
4 times, most recently
from
e55c917
to
f58a5ff
Compare
dschuff
reviewed
May 28, 2024
sbc100
force-pushed
the
dump_default_node_min_version
branch
from
f58a5ff
to
fbdfcb5
Compare
dschuff
approved these changes
May 28, 2024
There was a problem hiding this comment.
The change LGTM.
Note that the corresponding CL to change the version on Chromium CI is still blocked due to the hanging on the mac builder, and I haven't been able to reproduce it. I don't think this PR would break that (unless we start producing reftypes by default right away?), so we can try to solve that separately.
kripken
reviewed
May 29, 2024
sbc100
force-pushed
the
dump_default_node_min_version
branch
from
fbdfcb5
to
bde6d6e
Compare
sbc100
force-pushed
the
dump_default_node_min_version
branch
from
bde6d6e
to
3937670
Compare
dschuff
added a commit
that referenced
this pull request
May 30, 2024
dschuff
added a commit
that referenced
this pull request
May 30, 2024
msorvig
pushed a commit
to msorvig/emscripten
that referenced
this pull request
Jun 4, 2024
…scripten-core#22023) This is mostly a revert of commit 27b3050. It reverts the min node version in emscripten, but keeps the CircleCI configuration to test with node 18. This is a temporary workaround for emscripten-core#22022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See emscripten-core/emsdk#1387 See emscripten-core/emsdk#1173