Revert "Bump min node version to 18.20.3 (#22010)" #22023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
May 30, 2024
|
I decided to go back and keep the CI update; i.e. Circle will stay no node 18, so we can keep depending on it in tests. WDYT? |
lgtm |
msorvig
pushed a commit
to msorvig/emscripten
that referenced
this pull request
Jun 4, 2024
…scripten-core#22023) This is mostly a revert of commit 27b3050. It reverts the min node version in emscripten, but keeps the CircleCI configuration to test with node 18. This is a temporary workaround for emscripten-core#22022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a revert of commit 27b3050.
It reverts the min node version in emscripten, but keeps the CircleCI configuration to test with node 18.
This is a temporary workaround for #22022