Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourmash: init at 4.8.11 #288

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

luizirber
Copy link

@luizirber luizirber commented Mar 12, 2023

Similar PR in pyodide: pyodide/pyodide#3635

Mostly copied deps from https://github.com/conda-forge/sourmash-minimal-feedstock instead of what I did for pyodide, do I need to bring in the "pure python" deps too (or those can be pulled from conda-forge/PyPI?)

Note: this has a Rust extension, not sure if it works yet in emscripten-forge 😅

@wolfv
Copy link
Contributor

wolfv commented Mar 12, 2023

Nice! I think @DerThorsten did some work recently to enable rust on emscripten forge so there is a chance :)

@wolfv
Copy link
Contributor

wolfv commented Mar 12, 2023

Regarding pure python deps – everything that is available as a noarch package on conda-forge should work fine!

@DerThorsten
Copy link
Contributor

@wolfv @luizirber I am working on support for rust pyo3 packages but its not yet working

@luizirber
Copy link
Author

@wolfv @luizirber I am working on support for rust pyo3 packages but its not yet working

Nice!

Quick comment: sourmash is not a rust pyo3 package, it uses cffi for the bindings. It does use maturin as the build backend, which is more commonly used with pyo3 bindings.

@luizirber luizirber changed the title sourmash: init at 4.7.0 sourmash: init at 4.8.0 Apr 6, 2023
@luizirber luizirber marked this pull request as ready for review April 13, 2023 15:07
@luizirber luizirber changed the title sourmash: init at 4.8.0 sourmash: init at 4.8.2 Apr 25, 2023
@luizirber luizirber changed the title sourmash: init at 4.8.2 sourmash: init at 4.8.4 Sep 28, 2023
@luizirber
Copy link
Author

This has been open for some time, I updated to sourmash 4.8.4 but I didn't see any movement in the Rust support, so I don't think this will work yet =]

@DerThorsten
Copy link
Contributor

this needs to be converted to the new rattler-recipe format

Also rust packages with maturin are working now

@luizirber luizirber changed the title sourmash: init at 4.8.4 sourmash: init at 4.8.10 Jul 3, 2024
@DerThorsten
Copy link
Contributor

the error might be there because we use the a nightly version of the rust compiler tkaitchuck/aHash#200

I try to have a more detailed look on monday

@luizirber
Copy link
Author

I ran cargo update -p ahash and got v0.7.8 in sourmash now, as of sourmash-bio/sourmash#3243

when we release a new version there (probably 4.8.11) I'll update the PR here.

luizirber added a commit to sourmash-bio/sourmash that referenced this pull request Jul 9, 2024
@luizirber luizirber changed the title sourmash: init at 4.8.10 sourmash: init at 4.8.11 Aug 1, 2024
@luizirber luizirber force-pushed the lirber/sourmash_4.7.0 branch 5 times, most recently from 828e50d to 5a263de Compare August 1, 2024 00:28
emscripten-forge-bot and others added 3 commits August 8, 2024 21:54
Co-authored-by: emscripten-forge-bot <emscripten-forge-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants