Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button styles for Figma Design v2 #391

Open
OlenaReukova opened this issue Dec 16, 2024 · 0 comments · May be fixed by #397
Open

Button styles for Figma Design v2 #391

OlenaReukova opened this issue Dec 16, 2024 · 0 comments · May be fixed by #397
Assignees
@nichgalzin
Labels
☀️ high priority Necessary for a feature in development
Milestone
Browsing v2

Comments

@OlenaReukova
Copy link
Collaborator

OlenaReukova commented Dec 16, 2024 •
edited
Loading

Expected Behavior

We have a new Figma design that introduces updated button styles. The goal is to align our existing button UI with the new button styles while ensuring existing functionality remains unaffected.
Figma design

Image

Acceptance Criteria

  • New button styles match the Figma design.
  • Existing buttons retain their current functionality and behaviour.
  • New styles are implemented in a way that allows gradual integration and ensures future flexibility.
  • The Button UI should follow accessibility best practices.

Current Behavior

The existing button UI may not align with the new design.

Any other notes

No response

Assignment

This issue is free for anyone to take
@OlenaReukova OlenaReukova added the ☀️ high priority Necessary for a feature in development label Dec 16, 2024
@OlenaReukova OlenaReukova added this to the Browsing v2 milestone Dec 16, 2024
@OlenaReukova OlenaReukova moved this to Backlog in Kindly (enBloc) Dec 16, 2024
@OlenaReukova OlenaReukova added 🍎 core team This issue requires at least one member of the core team assigned to it and removed 🍎 core team This issue requires at least one member of the core team assigned to it labels Dec 16, 2024
@camelPhonso camelPhonso mentioned this issue Jan 2, 2025
Merged
@nichgalzin nichgalzin self-assigned this Jan 17, 2025
nichgalzin added a commit that referenced this issue Jan 17, 2025
@nichgalzin
style: adds offset to focus state
fdf7fe0 
Relates #391
nichgalzin added a commit that referenced this issue Jan 17, 2025
@nichgalzin
test: adds storybook file with variant storeis and basic play test
43b9eb3 
Relates #391
nichgalzin added a commit that referenced this issue Jan 17, 2025
@nichgalzin
build: organises component to it's own directory with storybook file
b93da10 
Relates #391
@nichgalzin nichgalzin linked a pull request Jan 17, 2025 that will close this issue
Open
nichgalzin added a commit that referenced this issue Jan 17, 2025
@nichgalzin
test: updates play test to fix test that runs on disabled button story
717931f 
Relates #391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nichgalzin nichgalzin

Labels
☀️ high priority Necessary for a feature in development
Projects
Kindly (enBloc)
Status: Backlog
Milestone
Browsing v2
Development

Successfully merging a pull request may close this issue.

391/v2 button styling enBloc-org/kindly
2 participants
@OlenaReukova @nichgalzin