391/v2 button styling #397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended to act as the main button used on the site, controls styling and variations with props, and attempts to enforce consistency, reusability and accessibility
nichgalzin
requested review from
OlenaReukova,
YuraPetrovskyi,
ShaughnAnderson94 and
camelPhonso
✅ Deploy Preview for cool-creponne-3e1272 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…and renames ligtMode to variant Relates #391
camelPhonso
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Babes, marked it as a request changes because I think we should avoid all that styling in the component file and it's definitely a better practice to extend native prop types over emulating them ourselves.
But overall I think making this a component is overkill but you might have been thinking of enforcing accessibility practices maybe ( ? ) so let me know what you think.
Good, nice, comprehensive documentation - I appreciate it much ✨
…yle system in figma Relates #391
camelPhonso
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
**Relates #390 & Closes #391 **
This pull request includes a new
MainButtoncomponent and its associated stories, as well as a minor update to the global CSS file to improve accessibility. The most important changes are detailed below.MainButton Component:
MainButtonComponent: Introduced a newMainButtoncomponent with various props to handle different button states and styles, includingvariant,size,colour,lightMode,type,disabled, andclickHandler. The component also includes default values and styles for each prop. (components/buttons/MainButton/MainButton.tsx)Storybook Stories:
MainButton: Added comprehensive Storybook stories for theMainButtoncomponent, showcasing different button states such as default, large, small, mobile, secondary, tertiary, light mode, and disabled. Each story includes appropriate args and a play function to test button interactions. (components/buttons/MainButton/MainButton.stories.ts)Global CSS:
outline-offsetfor the:focus-visiblestate to improve accessibility by making the focus outline more visible. (app/globals.css)UI changes
Component with props to match the above styling.
Tests
Storybook tests and stories as outline above.