You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted shrinkwrap then generated a clean new package-lock.json. Required a couple incidental additional updates for ESLint breaking changes that didn't follow semver.
@JayCanuck - Can you elaborate a bit for posterity on the eslint changes?
For clarity/posterity, the eslint/prettier changes were a result the ^ usage in devDependencies.
I like to use ^ in devDependencies for flexibility, while direct dependencies are exact (and npm releases shrinkwrapped. Prettier and import eslint plugin introduced lint-breaking changes contrary to semver policy. The commands/pack.js change is a result of prettier improving it's parsing ability, detecting new things to format correct. And the import change sets an explicit order for importing. This is done as a result of a known existing bug import-js/eslint-plugin-import#601 which accidentally omits "interna". It's planned to be fixed plugin-side in their 3.0 release and they're not planning any interim fixes, sadly, so it's up to us to explicitly declare as a workaround.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleted shrinkwrap then generated a clean new
package-lock.json. Required a couple incidental additional updates for ESLint breaking changes that didn't follow semver.Enact-DCO-1.0-Signed-off-by: Jason Robitaille jason.robitaille@lge.com