Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented defaults for import/order groups are inaccurate #601

Closed
mpalmer685 opened this issue Oct 4, 2016 · 1 comment · May be fixed by #608
Closed

Documented defaults for import/order groups are inaccurate #601

mpalmer685 opened this issue Oct 4, 2016 · 1 comment · May be fixed by #608
Labels

Comments

@mpalmer685
Copy link

From the documentation for the import/order rule's "groups" option:

The default value is ["builtin", "external", "internal", "parent", "sibling", "index"]

However, the rule's source file contains instead

const defaultGroups = ['builtin', 'external', 'parent', 'sibling', 'index']

where internal is missing. Not sure which of the two should be changed (I assume the source file), but this sent me on a wild goose chase this afternoon.

@jfmengels
Copy link
Collaborator

Good catch @mpalmer685!

Yeah, internal should be added to the source. Will try to fix this tonight, sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants