Fixed documentation for the default values for the order rule (fixes #601)
#623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Oct 12, 2016
There was a problem hiding this comment.
LGTM, not sure why tests are failing on master. @benmosher?
|
Hmm, looks like another dependency update breaking... Looking into it a bit. Anyway, thanks @ljharb for your advice :) |
|
Builds on master are broken, and the culprit is Babylon. I fixed the error and have made a PR over there babel/babylon#170. This is safe to merge, as it's just md files, but we'll need a new Babylon release before being able to have a working test suite. Tip: Do not remove your node_modules folder @benmosher :) |
|
@jfmengels released babylon@6.11.6 |
|
@hzoo Thanks! Tests are passing now :) |
|
Changes Unknown when pulling aeb7402 on fix-order-docs into * on master*. |
|
rebased and merged via 024a8a7 |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #601, and replaces #608.
cc @ljharb