Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-4591: Fix VideoPlayer to show only the mini feedback when pressing play/pause key #1701

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

mmyelyn
Copy link
Contributor

@mmyelyn mmyelyn commented Sep 26, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

There is an issue where the media slider appears when you press the play/pause button on the remote control.
But only mini feedback content should appear.

Resolution

I set the initial value for playbackRate.

Previously, the playbackRate value was always set via the setPlaybackRate function when the play and pause functions were called.
Now, playbackRate is set only when in seeking mode when the play/pause functions were called. Therefore, the initial value of playbackRate is missing and set to undefined. Because of this, the visibility conditions of the media slider have changed.

Additional Considerations

Links

WRR-4591

Comments

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.60%. Comparing base (37c8772) to head (1e366d9).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1701   +/-   ##
========================================
  Coverage    81.60%   81.60%           
========================================
  Files          148      148           
  Lines         6675     6676    +1     
  Branches      1987     1987           
========================================
+ Hits          5447     5448    +1     
  Misses         935      935           
  Partials       293      293           
Flag Coverage Δ
81.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
@MikyungKim MikyungKim changed the title WRR-4591: Set the initial value so that playbackRate is not undefined WRR-4591: Fix VideoPlayer to show only the mini feedback when pressing play/pause key Sep 30, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikyungKim MikyungKim merged commit 17c47f3 into develop Sep 30, 2024
7 checks passed
@MikyungKim MikyungKim deleted the feature/WRR-4591 branch September 30, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants