Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRR-4591: Fix VideoPlayer to show only the mini feedback when pressing play/pause key #1701

Merged
merged 3 commits into from
Sep 30, 2024
Merged

WRR-4591: Fix VideoPlayer to show only the mini feedback when pressing play/pause key #1701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd4bd76
Set the initial value so that playbackRate is not undefined
mmyelyn Sep 26, 2024
f71a071
Added a fixed log to CHANGELOG
mmyelyn Sep 26, 2024
1e366d9
Modified change log properly
mmyelyn Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ The following is a curated list of changes in the Enact sandstone module, newest
- `sandstone/Scroller`, `sandstone/Slider`, and `sandstone/VirtualList` to have default prop when `undefined` prop is passed
- `sandstone/Scroller` to show scroll indicator when `focusableScrollbar` prop is `true`
- `sandstone/Steps` prop `size` to accept number type
- `sandstone/VideoPlayer` to show only the mini feedback when pressing play/pause key

## [2.9.0] - 2024-07-17

Expand Down
1 change: 1 addition & 0 deletions VideoPlayer/VideoPlayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,7 @@ const VideoPlayerBase = class extends Component {
this.mediaControlsSpotlightId = props.spotlightId + '_mediaControls';
this.jumpButtonPressed = null;
this.playerRef = createRef();
this.playbackRate = 1;

// Re-render-necessary State
this.state = {
Expand Down